HalleyInteractive / brackets-notifications

Brackets - Notifications
MIT License
0 stars 0 forks source link

Define types of notifications #5

Closed HalleyInteractive closed 10 years ago

HalleyInteractive commented 10 years ago

Started a document describing different notification types: Wiki page

GriffinSauce commented 10 years ago

I think creating seperate implementations for every feature is a bit inefficient. Why not use only one notification function and add an options object. When no options are supplied, simply do the "simple" notif with just text,

Options object model: { image:, actions:[string,string] time:int }

The actions array can hold action names (like "Ok" and "Cancel"). On click, simply return those strings and let the notif-firing script handle it. Can be extended later with icon images.

Time:0 would mean forever until clicked.

HalleyInteractive commented 10 years ago

Sounds perfect! Maybe add the title and message to the object as well.

Probably only message needs to be mandatory.

GriffinSauce commented 10 years ago

So the total object with all suggestions should be:

{ title:string message:string image:base64 data, actions:[string,string] time:int }

GriffinSauce commented 10 years ago

I'm closing this issue to prevent it becoming an open discussion of everything and nothing.

The wiki should be kept updated. Seperate issues are added for the new ideas here that have not been done yet.