search

HaloOfBlocks / AdditionalGuns

A community addon for MrCrayfish's Gun Mod for 1.16 and above
https://www.curseforge.com/minecraft/mc-mods/additional-guns
GNU General Public License v3.0
16 stars 22 forks source link

Some guns don't render with the correct size on the back while on offhand. #89

Closed GaudiesHades closed 1 year ago

GaudiesHades commented 1 year ago

There are guns, like the AWM, AUG, M4A1-S, and some more that appear smaller on the back while they are on the offhand slot. This is an example:

AUG dropped in the ground:

2022-11-15_15 09 58

AUG while on offhand: 2022-11-15_15 10 10

As you can see, the size is different. It is easy to detect when this happens, especially in the AWM or the SSG-08.

Igggosha commented 1 year ago

No one noticed it before you because no one used the off hand anyways xd

GaudiesHades commented 1 year ago

I don't know, putting the gun in the back is a cool feature. But yeah you're right XD

CasualNoLifer commented 1 year ago

There are guns, like the AWM, AUG, M4A1-S, and some more that appear smaller on the back while they are on the offhand slot. This is an example:

AUG dropped in the ground:

2022-11-15_15 09 58

AUG while on offhand: 2022-11-15_15 10 10

As you can see, the size is different. It is easy to detect when this happens, especially in the AWM or the SSG-08.

@GaudiesHades

Hi, I'm going to be attempting to fix your issue soon depending on how the next several days go.

I have not played the recent Minecraft versions but is this a vanilla feature? If not, what mod is enabling items to be put on the back? If I can figure out what the mod is I can run some testing and figure out why sizing is different than it should be.

Thanks!

GaudiesHades commented 1 year ago

This feature is original to Mrcrayfish gun mod, but all the weapons in said mod work perfectly fine. It's just some guns in additional guns, like the ones I mentioned before and some more. For example, the Glock-18 being a small gun renders in the side of the leg, while larger weapons render on the back. As far as I know, only some large guns have this issue.

Autovw commented 1 year ago

If I remember correctly the item frame position is used for this feature. Guns that require two hands to hold render on the back of the player when placed in the off-hand and guns that require one hand to hold render on the side of the player in off-hand.

This is probably because we scaled the model down to better fit into the item frame. Should be easy to "fix".

GaudiesHades commented 1 year ago

Nice, happy to hear that! I thought it may had something to do with the item frame size, as Mrcrayfish gun mod weapons do go out of the item frame. Well, thanks!

Autovw commented 1 year ago

This issue should be resolved in Additional Guns 0.8.0. Feel free to re-open if you still encounter this issue. Thanks for reporting!