Resolve configuration for custom resolution, FOV, DSOAL

HaloSPV3 / HCE

HCE & SPV3 projects by Miris 'n' Crew.

https://source.n2.network/hce/

14 stars 0 forks source link

Resolve configuration for custom resolution, FOV, DSOAL #99

Closed SubhadeepJasu closed 3 years ago

SubhadeepJasu commented 3 years ago

BinToss commented 3 years ago

[x] Resolution can be changed (double-check native resolution code)
[x] FOV can be changed
[x] DSOAL can be enabled
[x] SSR performance warning only shown when the user toggles the setting.
[x] Persistent settings

BinToss commented 3 years ago

I may have found the cause of the FOV issue That's checking the non-SPV3 file path.

BinToss commented 3 years ago

This appears to be helpful when an invalid resolution is set, but less so if someone runs their game at a higher resolution than their desktop. I used to do that when I still used a Radeon HD 7870 GPU. Desktop was 1920x1080, but I ran games at 2560x1440 via VSR. I don't think we've run into this issue yet so I'll leave it be.

BinToss commented 3 years ago

The erased Loader settings may have been caused by assignments happening in the wrong order. I've changed the call order for SPV3.Configuration.Save() and Load().

BinToss commented 3 years ago

The patch still needs to be tested, so it's not ready to be merged.

BinToss commented 3 years ago

With the merging of #108, the checklist will be completed and this Issue is resolved.

BinToss commented 3 years ago

The Display Settings are still inconsistent See #113

MirisWisdom commented 3 years ago

Resolved by #114.