search

Halocrea / voice-chat-bot

🔊 A Discord bot that lets your community manage their own voice channels
16 stars 4 forks source link

TSLint -> Typescript-Eslint #24

Open Grenadator opened 4 years ago

Grenadator commented 4 years ago

The linter should be moved to Typescript-eslint as TSLint will become deprecated this year: https://github.com/typescript-eslint/typescript-eslint

angepagel commented 2 years ago

I'm on this! :^) Waiting for project dependencies to be upgraded (keeping an eye on PR #51) to install the latest versions of ESLint and its TypeScript packages.

angepagel commented 2 years ago

I propose the following config, based on the current .tslint.json:

.eslintrc.json

{
  "env": {
    "node": true
  },
  "extends": [
    "eslint:recommended",
    "plugin:@typescript-eslint/recommended"
  ],
  "parser": "@typescript-eslint/parser",
  "plugins": [
    "@typescript-eslint"
  ],
  "rules": {
    "arrow-parens": ["warning", "as-needed"],
    "comma-dangle": ["warning", "always"],
    "no-console": ["error", { "allow": ["warn", "error"] }],
    "quotes": ["warning", "single"]
  }
}
Grenadator commented 1 year ago

Looks fine to me

Worst case scenario we will update it if we need