search

HalosGhost / pbpst

A command-line libcurl C client for pb deployments
GNU General Public License v2.0
44 stars 9 forks source link

Change progress flag to something that plays nice with all shells. #62

Closed tmplt closed 8 years ago

tmplt commented 8 years ago

Some shells, or at least zsh, uses the # character. This requires the flag to be quoted when using pbpst. I suggest this is changed to a [a-zA-Z] character.

I planned to suggest -P or -T, but both of those are in use already.

HalosGhost commented 8 years ago

# is used mostly because curl uses it. However, I use zsh and do not find myself having to quote -#. Under what circumstances do you find yourself needing to quote it?

Also note that because --progress is valid, if that were ever a concern, you can fall back to it.

tmplt commented 8 years ago

I tried using -# in zsh -f and it appears that my zsh framework (zim) makes use of #. I was unaware of that.

HalosGhost commented 8 years ago

Ahh, I see. I am afraid I am not terribly moved to change this since it is cosmetic for most, and, again, is the flag chosen by the utility of our parent library. If you cannot make zim behave more normally, then I'd recommend using --progress.

tmplt commented 8 years ago

is the flag chosen by the utility of our parent library.

Understandable. I wouldn't change it either, especially as this issue isn't actually pbpst-based. This issue is closed for my part.