HalosGhost / pbpst

A command-line libcurl C client for pb deployments
GNU General Public License v2.0
44 stars 9 forks source link

Use of non-Async-Signal-Safe functions in signal handler #80

Closed HalosGhost closed 6 years ago

HalosGhost commented 7 years ago

As shown here, essentially everything we do in our signal handler is not really safe to call in a signal handler.

I am not sure that there is anything I can do about this, since the point of the signal handler is to fail out as gracefully as possible (we only catch SIGINT anyway) so the point is to clean everything up. But, I do want to document that this is the case on the off chance that it causes issues later.