HalosGhost / pbpst

A command-line libcurl C client for pb deployments
GNU General Public License v2.0
44 stars 9 forks source link

Replaced obsolete curl_formadd #92

Closed Hritik14 closed 5 years ago

HalosGhost commented 5 years ago

This is a great start! Thanks for taking a crack at it. It looks like there are a few build errors from this:

                } else if ( state.cmd != c ) {
                            ~~~~~~~~~ ^  ~
main.c:255:51: error: implicit conversion changes signedness: 'CURLcode' to 'int' [-Werror,-Wsign-conversion]
    if ( s->llex || s->lthm || s->lfrm ) { return pb_list(s); }
                                           ~~~~~~ ^~~~~~~~~~
main.c:261:26: error: implicit conversion changes signedness: 'CURLcode' to 'int' [-Werror,-Wsign-conversion]
        case UPD: return pb_paste(s);
                  ~~~~~~ ^~~~~~~~~~~
main.c:262:26: error: implicit conversion changes signedness: 'CURLcode' to 'int' [-Werror,-Wsign-conversion]
        case SHR: return pb_shorten(s->provider, s->url, s->verb);
                  ~~~~~~ ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
main.c:264:37: error: operand of ? changes signedness: 'CURLcode' to 'int' [-Werror,-Wsign-conversion]
                                  : pb_remove(s->provider, uuid, s->verb));
                                    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
5 errors generated.
make: *** [Makefile:36: bin] Error 1

I will poke around with cleaning it up in the next few days :)

Hritik14 commented 5 years ago

Those are not from the current PR. (They're in main.c and this commit doesn't touch this file).

Hritik14 commented 5 years ago

Solved the issue in #93 . Well, actually solving it would require a lot of unnecessary overhead.