search

Halpfrog / pe

0 stars 0 forks source link

Two companies can have the same phone number #2

Open Halpfrog opened 2 years ago

Halpfrog commented 2 years ago

Using the editCompany function I can change the phone number of one company to the same as another. It is unlikely that two companies would share the same phone number.

image.png

This can cause serious issues as the software is not prepared to handle mistakes like this, which can lead to the user having the wrong contact information for companies that might lead to serious miscommunication

soc-se-bot commented 2 years ago

[IMPORTANT!: Please do not edit or reply to this comment using the GitHub UI. You can respond to it using CATcher during the next phase of the PE]

Team's Response

This is not a bug as it was our team intended for this to be the case for these scenarios:

  1. Applying for companies via a recruiting company which can help you apply for multiple companies but the point of contact's details are the same
  2. Applying for companies that are subsidiaries of each other and have the same HR department

This was done intentionally to follow Prof Damith's advice on overzealous input validation:

image.png

also stated in UG:

image.png

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: [replace this with your reason]

:question: Issue severity

Team chose [severity.Low] Originally [severity.Medium]

Reason for disagreement: [replace this with your reason]