Halpfrog / pe

0 stars 0 forks source link

Two companies can share email address. #3

Open Halpfrog opened 2 years ago

Halpfrog commented 2 years ago

Two companies can share the same email address if it is edited using the editCompany command for example

editCompany 1 e/recruitment@amazon.com will lead to both companies sharing the same email

image.png

This is an issue as the user might very well send the email to the wrong address especially when they are meant to be juggling multiple intern opportunities and rely on this application to help them save time rather than have to double check each input they use.

soc-pe-bot commented 2 years ago

[IMPORTANT!: Please do not edit or reply to this comment using the GitHub UI. You can respond to it using CATcher during the next phase of the PE]

Team's Response

This is not a bug as it was our team intended for this to be the case for these scenarios:

  1. Applying for companies via a recruiting company which can help you apply for multiple companies but the point of contact's details are the same
  2. Applying for companies that are subsidiaries of each other and have the same HR department

This was done intentionally to follow Prof Damith's advice on overzealous input validation:

image.png

also stated in UG:

image.png

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: [replace this with your reason]


:question: Issue severity

Team chose [severity.Low] Originally [severity.Medium]

Reason for disagreement: [replace this with your reason]