search

Halpfrog / pe

0 stars 0 forks source link

Two companies can have the same address #4

Open Halpfrog opened 2 years ago

Halpfrog commented 2 years ago

Using the command

editCompany 1 a/Blk 30 Lorong 3 Serangoon Gardens, #07-18

I can change the address of company one to the second. It is very unlikely that two companies would share an address down to the unit number. Perhaps a warning to the user that this may not be true is a better solution when they share the same details to allow them to double check their details.

image.png

nus-se-script commented 2 years ago

[IMPORTANT!: Please do not edit or reply to this comment using the GitHub UI. You can respond to it using CATcher during the next phase of the PE]

Team's Response

This is not a bug as it was our team intended for this to be the case for these scenarios:

  1. Applying for companies via a recruiting company which can help you apply for multiple companies but the point of contact's details are the same
  2. Applying for companies that are subsidiaries of each other and have the same HR department
  3. Multiple companies can share the same building name and you don't always know the exact unit number and floor etc.

This was done intentionally to follow Prof Damith's advice on overzealous input validation:

image.png

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: [replace this with your reason]

:question: Issue severity

Team chose [severity.Low] Originally [severity.Medium]

Reason for disagreement: [replace this with your reason]