nus-pe-bot
commented
2 years ago Team's Response
This is not a bug. The undo/redo feature is intended as a proposed feature for future developers to consider implementing.
The undo/redo feature will be a useful feature for our application as it will allow users to quickly undo unintended changes made in, for example, the Edit Contact command.
Items for the Tester to Verify
:question: Issue response
Team chose [response.Rejected]
- [x] I disagree
Reason for disagreement: I noticed that I should have elaborated on this a bit more.
The problem with the current implementation of the proposed undo/redo feature is while it makes sense that the feature implemented can be useful, I felt like the proposed implementation does not integrate well with the implementations Advyze is working on. While undo/redo feature implemented could be useful, the proposed implementation does not follow the usual format of your DG. For example, you included the example usage scenario and undo/redo mechanisms behavior in the proposed undo/redo feature, however you did not add these behaviors anywhere else. I just felt like the DG is not written by the same people on that part, as there are practically no changes made by this from AB3.
I don't feel like the undo/redo feature is necessary in the application at all. In fact, I don't think you removed this from the DG. You might want to consider remove this as this is from the original AB3.