search

HamaIndustries / FEMultiPlayer-V2

Reupload & revamp of FEMP with fresh bugfixes... usually. Check "releases" for download.
http://eliatlarge.github.io/FEMultiPlayer-V2/
GNU General Public License v3.0
27 stars 31 forks source link

Anyone can Rescue Anyone without regard for what would be Rescued Unit's Weight / Con #41

Closed ghost closed 8 years ago

ghost commented 8 years ago

Issue type: problem

Description:

Currently, any unit can rescue another unit as weight / Constitution, and Aid haven't been implemented. This results in such curious scenarios as Matthew being able to rescue Oswin. Yes, I attempted this, and yes, the game let me. This applies to Giving and Taking as well.

I've been told that implementing Con and Aid stats, which would fix this, would involve tons of coding, so for the time being, a temporary / sloppy workaround would be to specifically list which units CAN'T be rescued by the rescuing unit.

EDIT: Changed title for clarification. Fixed typos

HamaIndustries commented 8 years ago

closed by commit 44046a9

HamaIndustries commented 8 years ago

ok, I'll do this the democracy way because I've never actually played the gba games

ghost commented 8 years ago

I probably should've explained better that rescuing is based solely on the rescuing unit's aid vs. the unit being rescued's weight aka Con, the problem is we lack those stats.

As a dirty jury-rigged workaround, we at least know the average weight and aide of each class, and with this we can make a list of what classes can rescue who. Keep in mind that the following is a very sloppy, "quick and dirty" workaround / solution.

Note that Pegasi and Troubadours / Valkyries are a weird exception who can rescue anyone, AND be rescued by anyone due to low Con.

Again, I'll stress that this is a "quick and dirty" fix suggestion that opts to make rescuing restrictions based on class instead of Con and Aid, by taking into consideration on average what units could rescue who in the official games without implementing the needed stats

HamaIndustries commented 8 years ago

This is good. When I get the time, I'll think up a con system. for now a tier thing can work.

ghost commented 8 years ago

Are tiers for rescuing set up for now until the Con system is ready? Or better yet, is Con system rescuing already ready since Shoving / Smiting (which is also Con based) was added?

HamaIndustries commented 8 years ago

closed by 5db0bb0.

all lord horse units recieved a +10 to con, to account for rescuing.

ghost commented 8 years ago

That wouldn't always be the case, some mounts and fliers are light enough to be rescued anyways. Like Florina's Con is 5 as a Falconknight, she's the lightest in perhaps the entire series. Eliwood's Con as Knight Lord is 9 btw. These units can still be rescued by someone with greater Aide (which usually is Rescuer's Con - 1; Fliers are a rare exception, they're much lighter than their aide)

HamaIndustries commented 8 years ago

then I should ignore con for mounted units?

ghost commented 8 years ago

Nah, cause most mounts are very heavy, such as your Paladins. It's really based on the unit, but some lords like Eliwood, and Falconknights are exceptions to the rule cause they have low Con but high Aide. Without an actual Aide stat, we're doing jury-rig by assuming the maximum Con of a unit someone can rescue is one less than their own Con.

HamaIndustries commented 8 years ago

can you specifically write out the rules to this one then?

HamaIndustries commented 8 years ago

btw, I uploaded a broken commit by accident, so moving any horse units will probably trigger a crash

edit: fixed in 5db0bb0d48556c01c6

ghost commented 8 years ago

can you specifically write out the rules to this one then?

You need to implement the Aid stat, as per #75

Without an Aid stat, it gets a bit messy for certain units. The best solution would be to add an Aid stat, then I'd just tell you the formula for calculating everyone's Aide. Because the way it's meant to work is that anyone whose Con is less than or equal to the rescuer's Aid stat, can be rescued. Likewise, you can't Give to a unit whose Aid is not greater than or equal to the Con of the person you're giving. Furthermore, you can't Take a unit from another unit if your Aid isn't greater than or equal to the Con of the unit you're trying to Take.

The formula for figuring out a unit's Aid is as follows:

If Rescuer's Aid ≥ Target's Con then they can Rescue / Take the target unit. When giving, it's relatively the same If Traveler's Con ≤ Target's Aid then the rescued person, (known as a Traveler), can be given to the target unit with the Give command.

So long as Aid is greater than or equal to the Con of the unit being Rescued or Taken, they can do so. When using Give, the unit you're passing a unit onto must have Aid that's greater than or equal to the unit being given to them.

EDIT: Clarification; Corrections

ghost commented 8 years ago

Closing as "Fixed" as per ef8aac58e448a3366a0c5e651af8f27850d1c1a4 and 0deb6b086bef454a4af410d276d19a057ce25537

Thank you @eliatlarge :-D

HamaIndustries commented 8 years ago

and with that, the saga ends. wew lad