search

Hamakor / pycon-israel

updates to Symposion for PyCon Israel
1 stars 5 forks source link

Footer links #28

Closed moshe742 closed 6 years ago

shaib commented 6 years ago

Did you intend for all links to be textual?

It's better than nothing, but I'd like something like

"Share: (facebook logo)(twitter logo)" "Follow or contact us: (envelope logo)(facebook logo)(twitter logo)"

moshe742 commented 6 years ago

changed the commits to have logos instead of text, the logos are a bit large but seems not bad on load time

AmitAronovitch commented 6 years ago
  1. rebased (moshe note: fetch+reset instead of pull if you have local repo checked out on that branch)
  2. added translation for the links
  3. Graphically, now the footer seems a bit too high (too many lines) to me, maybe reorganize?
shaib commented 6 years ago

Following the merge of #32 , this now has conflicts. I'll handle tonight if nobody gets to it first.