Hambergo / 9kmmrbot

MIT License
104 stars 29 forks source link

no matchid #44

Closed Satont closed 5 years ago

Satont commented 5 years ago
22|MMRBOT  |   {
22|MMRBOT  |     average_mmr: 5536,
22|MMRBOT  |     game_mode: 22,
22|MMRBOT  |     league_id: 0,
22|MMRBOT  |     lobby_id: '26281573975281419',
22|MMRBOT  |     lobby_type: 7,
22|MMRBOT  |     players: [
22|MMRBOT  |       [Object], [Object],
22|MMRBOT  |       [Object], [Object],
22|MMRBOT  |       [Object], [Object],
22|MMRBOT  |       [Object], [Object],
22|MMRBOT  |       [Object], [Object]
22|MMRBOT  |     ],
22|MMRBOT  |     server_steam_id: '90128480894820353',`
22|MMRBOT  |     weekend_tourney_bracket_round: 0,
22|MMRBOT  |     weekend_tourney_skill_level: 0,
22|MMRBOT  |     createdAt: 2019-08-22T21:49:19.905Z
22|MMRBOT  |   },

This is actual response from requestSourceTVGames, here is no match_id, but you trying to use it some later

let item = {
                            average_mmr: match.average_mmr,
                            game_mode: match.game_mode,
                            league_id: match.league_id,
                            match_id: match.match_id.toString(),
                            lobby_id: match.lobby_id,
                            lobby_type: match.lobby_type,
                            players: match.players,
                            server_steam_id: match.server_steam_id,
                            weekend_tourney_bracket_round: match.weekend_tourney_bracket_round,
                            weekend_tourney_skill_level: match.weekend_tourney_skill_level,
                            createdAt: now
                        }

It cause some issues

Env: node-dota: 6.2.0 steam: 1.4.0

I downgraded mine dependecies because of that issue https://github.com/Hambergo/9kmmrbot/issues/43

Hambergo commented 5 years ago

I commented on issue #43 for a probably better way to fix it, but in case you want to continue, you need to edit node_modules/dota2/proto/dota_gcmessages_client_watch.proto, need to add to CSourceTVGameSmall the line: optional uint64 match_id = 12;