search

HamedMasafi / Nut

Advanced, Powerful and easy to use ORM for Qt
GNU Lesser General Public License v3.0
294 stars 75 forks source link

Purpose of the NUT_FOREIGN_KEY macro? #69

Closed martonmiklos closed 4 years ago

martonmiklos commented 4 years ago

Hello @HamedMasafi

May I ask what was the intention with the NUT_FOREIGN_KEY: https://github.com/HamedMasafi/Nut/blob/2f439541a4c82345f43b885c9bc8f1fba770edb2/src/defines.h#L85

Is it left in accidentally or it was the start of something? I have not found any reference in the code to it.

I am working on upstreaming my join fix so I will poke around the NUT_FOREIGN_KEY_DECLARE/IMPLEMENT and if I am there it might be useful to remove it to remove confusion.

HamedMasafi commented 4 years ago

The NUT_FOREIGN_KEY was first version on master/slave (1:n) join mechanism, but later it spliced into two part of declaration/implementation. I thins it can now be deleted safely.

martonmiklos commented 4 years ago

Allright, thanks for the answer, I have removed it in #70