search

HamletDuFromage / 4chan-mass-reply

Easy mass replies on 4channel.org
GNU General Public License v3.0
30 stars 4 forks source link

Fixes and refactor #12

Closed soyware closed 2 years ago

soyware commented 2 years ago

Do the needful sir

HamletDuFromage commented 2 years ago

image >tabs

HamletDuFromage commented 2 years ago

On a more serious note, that is a little annoying that you did that Thank you for the improvements though, I'll go through them somewhat soon and merge it then

HamletDuFromage commented 2 years ago

Also I'm aware the current id is dumb (was just a placeholder that somehow stuck), but wouldn't changing it break updates from installed addons?

HamletDuFromage commented 2 years ago

I think I'm gonna cherry pick commits that fix bugs and manually add the useful lines from the commits that have heavy refactor. Then it should be pretty painless to merge your work @pixelplanetdev

Is there some commonly accepted formatting style for JavaScript? If so we do it properly in one commit after all is merged

HamletDuFromage commented 2 years ago

actually it looks like I had already merged the important stuff. I'll be closing the PR now. @soyware let me know if you think I missed something

soyware commented 2 years ago

Commits after e09ebdd make the popup look consistant across the browsers and some better variable naming as well as fixing printing that we compressed if we didn't.

@pixelplanetdev the reason for that change other than it's faster is that you can spam with all types of files (WebM, GIF, probably SWF and PDF) not just JPG and PNG, banning or filtering based on that would probably have many false positives.

I've merged the slider solver to my fork.

soyware commented 2 years ago

I just tested with a very small PNG and GIF files and at 95% of the contents being our random data it would still show correctly, I assume that's because file formats follow a structure and don't care what goes after it. Also "remember last used file" remembers the original file before we add the random (at least in my fork), so it doesn't grow in size if we continue to reuse the image. You'll probably get "attached image contains embedded file" error sooner than the image breaks. Also the reason that we use 8 bytes is that I tested with 2mb JPEGs and it were saying "dublicate file" if I used less than 6 random bytes, so I thought 8 bytes should suffice most boards's file size limits.

Didn't you just say that files with a random bytes at the end would stand out of the crowd and now you wanna add hidden messges? If you want to come up with something like that I think you should not make hidden message format be plain text and at least use base64 or something