Hammad887 / chat-app

0 stars 0 forks source link

web socket enhancement #20

Closed Hammad887 closed 11 months ago

Hammad887 commented 1 year ago
  1. Implemented Web Socket for real time notifications.
  2. Unit tests written for the web socket package
  3. Made some changes in swagger.yaml and db layer (Found some issues with CRUD operations while testing)
  4. Implemented Validation Checks to make sure only authenticated users can enter and send message to a particular chatroom.
shahzaibaziz commented 1 year ago

please attach demo screenshots

Hammad887 commented 1 year ago

I have uploaded a small video to demo the functionality. Here's the link: https://drive.google.com/file/d/1l31IjJrvoWk9nmKk_Wq9_xtkHosbXgx2/view?usp=sharing

shahzadhaider1 commented 1 year ago

Hammad, that's impressive.

  1. But I didn’t see any authentication being performed at the beginning. You didn’t provide any credentials, etc. did you do it before making the video?
  2. Could you create a third user and connect that user to a different chatroom and then send the message in the chatroom where first and second user are present? Now, this third user shouldn’t receive the message since this user is not a part of the chatroom where the message was sent.
Hammad887 commented 1 year ago

@shahzadhaider1 Yes, I did the authentication before making the video. Also, here's another video for the 3rd user you wanted me to create and test with the previously made chatroom. Link: https://drive.google.com/file/d/11YbK8n_fTDpPK8bKAxlg9wGoZyLLb9RB/view?usp=sharing

shahzadhaider1 commented 1 year ago

Alright, good work.

shahzaibaziz commented 1 year ago

Good work! Kudos to @Hammad887 for putting a lot of effort into it

Hammad887 commented 11 months ago

@shahzaibaziz I have changed all the filenames to snake case. Thank you so much for imparting this knowledge. Also, added a websocket handler which addresses most of the changes you asked me to resolve in the websocket-server.go file in the previous commit.

I will need to discuss the dockerfile and docker-compose on a call once everything else gets resolved.