search

Hammerling-Research-Group / placement

Production code for Sensor Placement Optimization
https://ams.mines.edu/hammerling-research-group/research/placement
MIT License
0 stars 1 forks source link

batch 3 #12

Closed pdwaggoner closed 1 month ago

pdwaggoner commented 1 month ago

Are all of the extra build and make files (and test_data) needed from FastGaussianPuff?

Also, please double check that all file paths are correct, and also the demo subdirectory structure over in #11 is correct. Thanks!

pdwaggoner commented 1 month ago

Of note, looks like there were a few typos (hence the failed checks). Feel free to make those corrections or leave them for now. Once the code is up, we can make the changes later if you'd like, given that this is more of a cosmetic check. So if you're comfortable, you can merge with this failed check. Otherwise, let me know. Happy to correct if needed ahead of merging. Thanks!

maverickjia commented 1 month ago

Are all of the extra build and make files (and test_data) needed from FastGaussianPuff?

Also, please double check that all file paths are correct, and also the demo subdirectory structure over in #11 is correct. Thanks!

test_data is not necessary to run Fast Gaussian puff but I'm not quite sure for other files. Just keep all files for now. We can check with Ryker later.

maverickjia commented 1 month ago

Of note, looks like there were a few typos (hence the failed checks). Feel free to make those corrections or leave them for now. Once the code is up, we can make the changes later if you'd like, given that this is more of a cosmetic check. So if you're comfortable, you can merge with this failed check. Otherwise, let me know. Happy to correct if needed ahead of merging. Thanks!

Let’s go ahead and leave them as they are.

pdwaggoner commented 1 month ago

Awesome. Done.