Hammerling-Research-Group / placement

Production code for Sensor Placement Optimization
https://ams.mines.edu/hammerling-research-group/research/placement
MIT License
0 stars 1 forks source link

Add a wind speed filter in step1_generate_emission_scenarios.ipynb #22

Closed maverickjia closed 1 week ago

maverickjia commented 1 week ago

This update introduces a filter in step1_generate_emission_scenarios.ipynb to exclude invalid wind speed values. Specifically, a lower bound (ws_lb) and an upper bound (ws_ub) have been set to define the acceptable range for wind speed values.

pdwaggoner commented 1 week ago

@maverickjia the spell check linter flagged these issues (you can also inspect if you look at the checks output):

./demo/step1_generate_emission_scenarios.ipynb:155: optinal ==> optional
./demo/step1_generate_emission_scenarios.ipynb:15[6](https://github.com/Hammerling-Research-Group/placement/actions/runs/11827641896/job/32956181962?pr=22#step:4:7): optinal ==> optional
./demo/step1_generate_emission_scenarios.ipynb:237: fo ==> of, for
./demo/step1_generate_emission_scenarios.ipynb:23[7](https://github.com/Hammerling-Research-Group/placement/actions/runs/11827641896/job/32956181962?pr=22#step:4:8): OpeG ==> open
./demo/step1_generate_emission_scenarios.ipynb:237: Ba ==> By, be
Error: Process completed with exit code 65.

Can you verify that these terms are correct, and if not, please correct the spelling? Thanks!

maverickjia commented 1 week ago

I've corrected some of the typos. However, I couldn't locate these 3 errors in step 1 code: ./demo/step1_generate_emission_scenarios.ipynb:237: fo ==> of, for ./demo/step1_generate_emission_scenarios.ipynb:237: OpeG ==> open ./demo/step1_generate_emission_scenarios.ipynb:237: Ba ==> By, be

pdwaggoner commented 1 week ago

I couldn't either. What I think it is, is in those extremely long num-char strings that are unfortunately unique to jupyter notebooks, it detected some odd combination of characters. As long as you've had a look and the code is correct, that's the most important thing. Thanks! Merged.