Hammerspoon / Spoons

The official repository of Spoon plugins
https://www.hammerspoon.org/Spoons/
450 stars 141 forks source link

WindowSigils: Fixes and support for stacking windows and empty spaces #241

Closed eraserhd closed 2 years ago

eraserhd commented 3 years ago

This incorporates the commit from #239 (thanks @erbridge) , and #239 should partially fix #238.

Window Stacking

In addition, I had some nice improvements that I never submitted that allow stacking windows nicely. When two windows have the same position:

  1. Use the OS window id when sorting to keep the assigned sigils stable. (It used to depend on tab order, and so they would keep moving around).
  2. Prevent the sigil indicators themselves from overlapping on the screen. They are now spaced out nicely so you can select a window as though it were a kind of tabbed control.

For example:

WindowSigils

A Note: Planned Future Features

Not a part of this PR, but coming up in hopefully not more than a few weeks:

eraserhd commented 3 years ago

CI failure appears unrelated?

eraserhd commented 2 years ago

@cmsj Could you review and merge this? It fixes multiple issues in WindowSigils.

In addition, I just stacked an "empty window" feature on top of this PR. I've been using this code for months, and this brings the spoon up-to-date with what I'm using and maintaining.

eraserhd commented 2 years ago

This also closes #238.

cmsj commented 2 years ago

Thanks @eraserhd - apologies for the slow response.