Hammerspoon / Spoons

The official repository of Spoon plugins
https://www.hammerspoon.org/Spoons/
450 stars 141 forks source link

Implemented customization of the size of the cheatsheet and order of … #253

Closed dmgerman closed 3 months ago

dmgerman commented 2 years ago

I find ModalMgr to be an amazing spoon. but it has some usability problems:

  1. The window is too wide. I frequently have to rotate my head to be able to read all the options
  2. The ordering makes it difficult to find items. One has to go left-right-left-right to read the options
  3. the size of the window is hardcoded. it is too wide, this means my eyes have to move to read the options.

I have added customization. Basically these variables:

-- customize width and height of Cheatsheet
obj.width_factor = 0.30
obj.height_factor = 0.30
-- minimum sizes
obj.min_width = 200
obj.min_height = 200

-- alighment for right column
obj.alignmentRightColumn = 'right'
obj.fillByRow = false

One extra advantage of these changes is that each ModalMgr window can have different sizes or filling strategies.

cmsj commented 2 years ago

ping @ashfinal as author of ModalMgr

dmgerman commented 2 years ago

I am sorry, I don't know if there is anything I should do to have the checks passed.

cmsj commented 2 years ago

I am sorry, I don't know if there is anything I should do to have the checks passed.

Annoyingly GitHub makes it extremely difficult to run checks when third parties submit PRs and still be able to report useful results. Please ignore the failing checks.

dmgerman commented 1 year ago

I have rebased the pull request. Is there anything else that I should do?