search

Hammerspoon / Spoons

The official repository of Spoon plugins
https://www.hammerspoon.org/Spoons/
453 stars 141 forks source link

Process to update Spoon repository #318

Closed asmagill closed 5 months ago

asmagill commented 6 months ago

@cmsj, I'm going to have some time in the next few days to start landing some of the outstanding spoons and pull requests for Hammerspoon.

I'm not sure what the deployment process is for Hammerspoon -- that's a whole other conversation if you want me to be able to manage that (including whether or not we have a team certificate, how to handle that going forward, etc.)

But for spoons, I recall you telling me that you thought the process was pretty much automated once I commit to the master (main) branch -- but I can't find that conversation now. So... is my recollection correct? Can I just start reviewing and merging?

Thanks!

cmsj commented 6 months ago

In theory yes, merging Spoons should trigger a full build/publish update, but I haven't done it in a while, so it could be broken 😬

asmagill commented 5 months ago

Ok, that looked like it worked for my LeftRightHotkey spoon... it created the docs.json file, created the zip file, and updated the published Spoon doc pages... I think that's all?

It will probably be Tuesday or so before I can really start reviewing the backlog here in the Spoons repository and applying them (traveling ATM, but wanted to verify the process), but I hope to have the Spoons repo up to date in the next weekish.

That still leaves the Hammerspoon repo, but ATM too much of that is tied specifically to you and your system... I can merge (and will, after catching up with the Spoons) but I can't create releases.

asmagill commented 5 months ago

Closing. Reopen if you think there is something that was missed in the process and needs to be addressed before I go forward.

asmagill commented 5 months ago

Ugh... may have spoken too soon... got an email that some jobs were not completed because they were cancelled... (see https://github.com/Hammerspoon/Spoons/actions/runs/9334839163/job/25693536338).

@cmsj, is this a problem? Like I said, the docs at https://www.hammerspoon.org/Spoons/LeftRightHotkey.html look good, and the source and zip files look good.

asmagill commented 3 months ago

@cmsj -- Since you seem active/available atm, figured I'd poke you about this one again -- can I safely ignore the failed jobs with Spoons? I know I can re the CI tests for Hammerspoon itself..

cmsj commented 3 months ago

@asmagill hmm, I'm not sure immediately why the run was cancelled, but if all the pieces look good I think let's not question it ;)

I'll work through the PRs in this repo once I'm done with a HS release, and see if anything goes wrong with those.