Hammerspoon / hammerspoon

Staggeringly powerful macOS desktop automation with Lua
http://www.hammerspoon.org
MIT License
11.99k stars 582 forks source link

Release 0.9.51 #1130

Closed cmsj closed 7 years ago

cmsj commented 7 years ago

Ok folks, let's fire up the release train again! Get your nominations in for bugs/PRs to land :)

junkblocker commented 7 years ago

@asmagill , do you think you can include #1116 ? :)

asmagill commented 7 years ago

Re #1116, suggestions on the name? I've been calling it hs._asm.watchable, which usually means it would be called hs.watchable when added to core, but it doesn't have to be.

@cmsj, per your comment in the Google groups thread about including examples in the API docs... what are your thoughts on adding a "Sample" entry type? I think as long as we kept the "label" for the example one contiguous string with no spaces (e.g. hs.module.example_name) it won't break any scripts, but I'd have to run some tests to be certain.

junkblocker commented 7 years ago

@asmagill . :+1: for hs.watchable. Fits the established hs terminology and the purpose better than a more general hs.observable IMHO.

asmagill commented 7 years ago

@cmsj (and anyone else that wants to chime in), here is a list of things I've been working on that could be ready in the next couple of days, depending upon how quickly you want to get 0.9.51 out, and I'd like to get your thoughts on priorities and/or things to definitely include or hold off on:

I want to hold off, unless there is disagreement, on the following for now:

latenitefilms commented 7 years ago

My thoughts, for what it's worth (which is probably very little)...

I completely agree with everything @asmagill has said. I agree that eventually all @asmagill's magical hs.axuielement code should make its way into hs.uielement. We've been using this code EXTENSIVELY, and it's so great.

I've also been using hs.touchbar for a while now, and it's been rock solid for me, but more than happy to trust your genius as to if and when you should release!

Some things I'd personally LOVE to see in the next release if anyone's up for the challenge and there's enough time to do before you want to release publicly:

Thanks so much to EVERYONE who contributes to Hammerspoon. You're all seriously impressive and inspirational. Hopefully once I eventually get better at coding in LUA, I'll actually be able to contribute something to the codebase!

asmagill commented 7 years ago

Drag and drop to a NSStatusItem requires a custom view -- see http://stackoverflow.com/a/6006530. If this is to be added, it should probably be done with a menubar rewrite since we're heavily utilizing methods deprecated in 10.10 for hs.menubar and it really should be redone using the button property for everything so it's more flexible and forward-compatible.

https://github.com/asmagill/hammerspoon_asm/tree/master/preferences looks like it might be useful for reading property list files. I need to revisit it and add support for writing back changes (currently its read-only), so it's not going to make 0.9.51, but I should be able to work on it after the new year.

I should be able to get canvas added in the next day or two, and I'd like one more crack at propertylists with the pasteboard module, but other than that, I think we're pretty close to ready.

latenitefilms commented 7 years ago

Drag and drop to a NSStatusItem requires a custom view -- see http://stackoverflow.com/a/6006530. If this is to be added, it should probably be done with a menubar rewrite since we're heavily utilizing methods deprecated in 10.10 for hs.menubar and it really should be redone using the button property for everything so it's more flexible and forward-compatible.

Thanks so much for looking into this! HUGELY appreciated! No worries at all. I've since worked out a way to do "drag and dropping" using hs.webview, which works great! Eventually, I'd still love to be able to drag and drop to hs.menubar, but it's not super urgent.

https://github.com/asmagill/hammerspoon_asm/tree/master/preferences looks like it might be useful for reading property list files. I need to revisit it and add support for writing back changes (currently its read-only), so it's not going to make 0.9.51, but I should be able to work on it after the new year.

Yeah, I have had a quick look at your preferences module, but to be honest, I couldn't really wrap my head around it. If you're able to have a look at it next year, that would be amazing!

Thanks for your ongoing help and support!!

cmsj commented 7 years ago

(Apologies, I'm not ignoring this discussion, I'm just in a pre-Christmas work crunch. I will have lots more time in the second half of next week)

asmagill commented 7 years ago

np, figured as much... I'm trying to wrap up the low hanging fruit since I've got the time...

cmsj commented 7 years ago

It seems like we're in pretty good shape here, last call for any things that are super important to be done right now, and then I'll try and get 0.9.51 out in the next couple of days :)

cmsj commented 7 years ago

I broke Travis, Happy Christmas ;) I think it's the trick I was using to discover where to load Lua test files from. Will investigate tomorrow/Monday.

latenitefilms commented 7 years ago

One day you're gonna have to explain to me what/who Travis is. Regardless, Merry Christmas and thank you SO MUCH for all your amazing help and support over the last few months! HUGELY appreciated!!! You too @asmagill - thank you, thank you, thank you.

cmsj commented 7 years ago

@latenitefilms Travis is travis-ci.org - every time we push a new commit into Hammerspoon, they do a full build and run the test suite, and report back the results. It can be infuriating when it's broken, but it helps us catch mistakes :)