search

Hammerspoon / hammerspoon

Staggeringly powerful macOS desktop automation with Lua
http://www.hammerspoon.org
MIT License
11.96k stars 579 forks source link

windowHints hotkey modal clashes with user defined modals #606

Open rcoedo opened 8 years ago

rcoedo commented 8 years ago

It seems like windowHints implementation is based on modal hotkeys, and it defines a global variable named "k" for the modal. That global variable was clashing with my own modal variable (also named "k") causing weird behavior. Changing my modal variable name fixed it.

I'm not experienced enough with hammerspoon or lua to fix this myself. Is it possible to use a local variable in the windowHints module? Maybe the windowHints variable should have a less common name?

I believe this is the line causing trouble.

Thanks!

cmsj commented 8 years ago

hmm, yeah that does look like it should be local to the function in question. Thanks!

latenitefilms commented 4 years ago

@cmsj - I believe this issue was fixed when we corrected all the @stickler-ci reported issues, and can be closed.