HamnaNimra / SYSC4907-SAV

Capstone project for SYSC4907 Simulated Autonomous Vehicle fall 2020- winter 2021
1 stars 3 forks source link

General issues observed in LKA #6

Open pgavigan opened 3 years ago

pgavigan commented 3 years ago

Messages out of lka include lanes, margins, steering, request It is unclear what the /request topic is for. Why was steering message commented out on line 122 rather than publishing steering automatically.

Line 116 of LKA produces a new publisher inside a loop. This can lead to problems. It should only happen at the beginning of the program.

All publishers and subscribers need to be documented to clarify how the topics should be used to facilitate future integration.

Possible issue with the names of some topics: obstacle avoid and stop sign detection both publish as LKA - possibility for confusion here.

JaskaranSinghW commented 3 years ago

The issue of new publisher being created inside loop has been fixed from LKA, ACC and Obstacle Detection Modules.

The Steering message is bring published from the cll function instead of line 122.