search

HamoyeHQ / 05-bitcoin-trading

6 stars 8 forks source link

added skeleton of models being worked on #29

Closed jecordjotse closed 3 years ago

jecordjotse commented 3 years ago

Comments are not the best. Working on card

Decomposition with the card link ADF Test with the card link ACF & PACF with the card link ARIMA with the card link LSTM with the card link

Jolomi-Tosanwumi commented 3 years ago

Not the best of comments indeed. You can use markdown cells to name sections of your notebook and comment on it to improve readability. My observations:

  1. your time series is already stationary...the ADF test says so. No need for differencing.
  2. From your ACF and PACF plots, it ought to have been ARIMA(2, 0, 16) for the weekly time frame and ARIMA(1, 0, 3) for the monthly time frame without differencing.
  3. I think there is no need of printing out all the generated future in your LSTM notebook. You could just print out the first 5 sequences.
  4. Your RMSE score was not calculated for the last model in the LSTM notebook.

So, I am closing this pull request so fix in the corrections.