This PR adds an option to support the shuffle of individual ocarina notes. It is found under the shuffle frogs option.
This PR adds the logic helper has_song. I replaced all instances of ocarina,lullaby with $has_song|lullaby, and all instances of has("ocarina") and has("lullaby") with has_song("lullaby").
TODO:
[ ] The image files I provided are just placeholders and should be replaced
[ ] The new row in the item grid should not appear when this option is disabled (I don't know how to do this)
[x] From OOTR docs: The skull kid ocarina minigame is not considered to be in glitchless logic until all 5 notes are found
[x] Order of note items in the layout should match the order they appear in the pause menu in-game, which is: A down right left up
Should be verified:
[ ] I made this option disabled by default in all presets
[ ] Line 261 in logic_helpers.lua has suspicious use of and and or - I replaced this with a single has_song which may affect the logic here. I don't know Lua well enough to confirm
[ ] Changes to access rules for SFM Storms Grotto and Deku Tree MQ GS Basement Graves Room mean they now require the ocarina
This PR adds an option to support the shuffle of individual ocarina notes. It is found under the shuffle frogs option.
This PR adds the logic helper
has_song. I replaced all instances ofocarina,lullabywith$has_song|lullaby, and all instances ofhas("ocarina") and has("lullaby")withhas_song("lullaby").TODO:
Should be verified:
logic_helpers.luahas suspicious use ofandandor- I replaced this with a singlehas_songwhich may affect the logic here. I don't know Lua well enough to confirmSFM Storms GrottoandDeku Tree MQ GS Basement Graves Roommean they now require the ocarina