Hamunii / JetpackFallFix

A lethal company mod which fixes buggy jetpack fall damage logic.
MIT License
0 stars 0 forks source link

JetpackFallFix breaks other mod "ModelReplacementAPI" by BunyaPineTree #2

Open rocketbuuny opened 4 months ago

rocketbuuny commented 4 months ago

When your mod is enabled, it prevents ModelReplacementAPI from changing models used when equipping a suit for unknown reason. When JetpackFallFix is enabled, I look like this: image

When JetpackFallFix is not enabled, ModelReplacementAPI works as expected and replaces the model like this: image

Using AFK emote from "TooManyEmotes" by FlipMods (v2.1.14) to go into third person

Using DragonBlack suit from "ThiccCompanyModelReplacement" (v2.0.1) by FoxGod to show ModelReplacementAPI breaking, but all other mods that have ModelReplacementAPI as a dependency also look broken

Also submitted this issue on the Github for ModelReplacementAPI by BunyaPineTree here

Hamunii commented 4 months ago

Thanks for the bug report! It seems that there is no actual incompatibility between these mods, it just appears that Harmony patches shit themselves when an ILHook throws, which isn't ideal. I'll fix this though soon