Closed linsui closed 5 months ago
Hamza417
commented
5 months ago I've updated the APK that should correspond to commit 6130420 used in the release tag. However, as I recall, I built the APK only after pushing the changes and not sure why it'd show an error.
linsui
commented
5 months ago Maybe the result is cached? :shrug: Thanks!
licaon-kter
commented
5 months ago can you reopen?
ref: https://gitlab.com/fdroid/fdroiddata/-/jobs/6486205309#L804
maybe based on https://gitlab.com/fdroid/fdroiddata/-/issues/3138 and https://developer.android.com/jetpack/androidx/releases/compose-kotlin#pre-release_kotlin_compatibility
can you update https://github.com/Hamza417/Peristyle/blob/v1.38_beta/build.gradle#L5 to 1.9.23 and https://github.com/Hamza417/Peristyle/blob/v1.38_beta/app/build.gradle#L52 to 1.5.11?
Diff log is rather small:
│ │ │ │ │ │ --- peristyle138/smali/app/simple/peri/ui/WallpaperScreen$onCreateView$1$1.smali
│ │ │ │ │ ├── +++ app.simple.peri_138/smali/app/simple/peri/ui/WallpaperScreen$onCreateView$1$1.smali
│ │ │ │ │ │ @@ -473,15 +473,15 @@
│ │ │ │ │ │
│ │ │ │ │ │ move-result-object v7
│ │ │ │ │ │
│ │ │ │ │ │ move-object v11, v7
│ │ │ │ │ │
│ │ │ │ │ │ check-cast v11, Landroidx/compose/ui/layout/ContentScale;
│ │ │ │ │ │
│ │ │ │ │ │ + const v7, 0x68889e12
│ │ │ │ │ │ - const v7, 0x58482b1f
│ │ │ │ │ │
│ │ │ │ │ │ invoke-virtual {v1, v7}, Landroidx/compose/runtime/ComposerImpl;->startReplaceableGroup(I)V
│ │ │ │ │ │
│ │ │ │ │ │ invoke-virtual {v1, v2}, Landroidx/compose/runtime/ComposerImpl;->changed(Ljava/lang/Object;)Z
│ │ │ │ │ │
│ │ │ │ │ │ move-result v7I tried changing the versions as you stated, but I got Caused by: java.lang.RuntimeException: Compose Multiplatform 1.5.11 doesn't support Kotlin 1.9.23.
licaon-kter
commented
5 months ago did you by any chance mix these two?
Hamza417
commented
5 months ago No I didn't, it worked now, I had to update the plugin version as well, should I publish a new release or republish the current tag?
licaon-kter
commented
5 months ago whatever gets us an APK to test against
Hamza417
commented
5 months ago I've republished it, Could you check again?
licaon-kter
commented
5 months ago Hamza417
commented
5 months ago The build succeeded this time, thanks.
Number of signers: 1
2024-03-27 16:17:36,201 INFO: ...successfully verified
2024-03-27 16:17:36,201 INFO: compared built binary to supplied reference binary successfully
2024-03-27 16:17:36,204 DEBUG: Using androguard from "/usr/lib/python3/dist-packages/androguard/__init__.py"
2024-03-27 16:17:36,220 INFO: Starting analysis on AndroidManifest.xml
2024-03-27 16:17:36,228 INFO: APK file was successfully validated!
2024-03-27 16:17:36,232 DEBUG: Using APK Signature v2
2024-03-27 16:17:36,233 INFO: supplied reference binary has allowed signer 4a3f711142250805c7bb5c0a5a3287631bdb948816e6f4afc9524d0eb46b6b1b
2024-03-27 16:17:36,234 INFO: success: app.simple.peri
2024-03-27 16:17:36,234 INFO: Finished
2024-03-27 16:17:36,234 INFO: 1 build succeeded
https://monitor.f-droid.org/builds/log/app.simple.peri/137#site-footer
You built your apk from a different commit. I'll use your commit for this version. Could you please make sure that your apk is built from the tag? Or you can disable the vcs info. See https://github.com/SagerNet/sing-box-for-android/commit/720b5621d2d1a6dcc0a5aa6c5b3af76ba1cec443 for example.