Hamza417 / Peristyle

Simple wallpaper manager app for Android with awesome UI written completely in Jetpack Compose.
Apache License 2.0
200 stars 4 forks source link

FR: Custom cropping area #67

Open mihawk90 opened 4 weeks ago

mihawk90 commented 4 weeks ago

Currently - as far as I can tell after first use - it seems to be only possible to either use a cropped image based on the currently visible part of the image, or use an entire uncropped image as is.

The former disables wallpaper scrolling because it of course fits the screen 1:1, the latter results in very wide swings for larger images (or even standard 16:9 aspect ratio), possibly with not much to show on every screen or characters in the image being cropped off.

It would be nice to be able to define a custom cropping area so that one could crop to for example a 1:1 aspect ratio area within the image, which would result in much less of a swing when scrolling the wallpaper.

Hamza417 commented 2 weeks ago

Is it aspect ratio based cropping?

mihawk90 commented 2 weeks ago

I'm not sure which one would be easier, but having an aspect ratio selector would certainly be nice.

For an example you could take a look at the editing UI of Leafpic (Revived) (which I ended up using to crop the image beforehand). It's unfortunately abandoned now but it still "works". The only issue I have with their implementation is that the aspect ratio isn't maintained when resizing the selected area. For example setting it to 1:1 sets the selection to full height but when you want to reduce the size, it ignores the selected aspect ratio and you're back to arbitrary ratios, so you basically have the choice between full-height 1:1 or arbitrary aspect ratio.

edit: A better example might be Fossify Gallery since it doesn't have that issue.