Han434 / pocketedDays

0 stars 0 forks source link

Week 5 is ready for review #5

Closed Han434 closed 1 year ago

Han434 commented 1 year ago

"@pawaitemadisoncollege week 5 is complete"

  1. Using hibernate is tricky.
  2. Missing Annotation is something that I got wrong this week.
  3. I figured out why we should use a set for collection. I pay a lot for that.

Although I posted that everything is going fine in slack later I realized that the treemap is not sorted properly. If that is alright, could you possible provide any feedback on that matter?

pawaitemadisoncollege commented 1 year ago

Hi @Han434 Wow! You have done a lot of work here!!! Lots of servlet functionality!

Can you share a bit more about what you observed with the treemap/treeset? If you could share in slack how it is currently sorting and how you would like it to sort, that would help, and I'm sure the conversation will help others too!

Han434 commented 1 year ago

@pawaitemadisoncollege Can you help me figure out how I can test the delete scenarios? Thanks.

pawaitemadisoncollege commented 1 year ago

Hi @Han434 You asked me to review this and update your mark in Blackboard. Can you point me to screenshots showing all unit test pass when run together? Thanks!

Han434 commented 1 year ago

Screenshot 2023-05-02 192536

@pawaitemadisoncollege

pawaitemadisoncollege commented 1 year ago

Thanks! Regarding that renaming error - I think others may have run into this as well and posted in Slack. Ultimately, I think windows doesn't allow colons in the file name.