HanSolo / SpaceFX

Just a simple tiny space game written in JavaFX
Apache License 2.0
163 stars 33 forks source link

How do I build this on mac? #2

Open cschneider opened 4 years ago

cschneider commented 4 years ago

I tried to use the build-app.sh but got some errors. One is: build_app.sh: line 69: /Library/Java/JavaVirtualMachines/adoptopenjdk-8.jdk/Contents/Home/bin/jlink: No such file or directory

I got the directory but it does not contain jlink. Does this not work on java 8? Can I build/run the game without creating a native package? I am more interested in the javafx aspects.

sormuras commented 4 years ago

jlink was introduced with JDK 9: https://docs.oracle.com/javase/9/tools/jlink.htm

Does this not work on java 8?

Nope. Not as-is.

Can I build/run the game without creating a native package?

Commenting out all jlink related lines should do the trick. For example:

https://github.com/HanSolo/SpaceFX/blob/908d3017c568fea09b84fbbfd8d3365a17f39b5b/build.gradle#L24

sormuras commented 4 years ago

Or better: install and use JDK 13 or at least a maintained JDK 11 on your box. šŸ˜‰

HanSolo commented 4 years ago

Well this project is based on JDK11 incl. modules. Iā€˜m also on Mac and it works perfectly fine šŸ˜

sormuras commented 4 years ago

Dooh. Of course. Modules! šŸ¤“

That renders my first answer useless.