search

HanSolo / SteelSeries-Canvas

The HTML5 Canvas port of the SteelSeries component library. Mainly contains gauges.
120 stars 76 forks source link

Clock.setSeconds() weirdness #13

Closed java-artisan closed 10 years ago

java-artisan commented 10 years ago

I'm using the Clock to show the time stamp of data from a server machine. It is therefore disabled. The setter functions are used to set the hands accordingly.

The hours and minutes seem to work. The seconds however are working strange. Once in a while the seconds hand will move. But usually doesn't. While I'm pretty sure the seconds passed are in the expected range of 0 to 59.

java-artisan commented 10 years ago

I might be wrong, but it looks like the seconds hand is stuck at the 57 seconds position.

mcrossley commented 10 years ago

Thanks, yes the .setSecond() method is broken, I'll fix it. Simple fix, line 9407, is.. second = parseInt(newVlaue, 10) % 60; should be... newValue = parseInt(newValue, 10) % 60;

mcrossley commented 10 years ago

Version 0.14.9 uploaded that addresses this issue, can you confirm it is fixed?

java-artisan commented 10 years ago

I'll check it tonight and update accordingly.

Thanks !

On 05/27/2014 04:52 PM, Mark Crossley wrote:

Version 0.14.9 uploaded that addresses this issue, can you confirm it is fixed?

— Reply to this email directly or view it on GitHub https://github.com/HanSolo/SteelSeries-Canvas/issues/13#issuecomment-44286745.

java-artisan commented 10 years ago

I've got one smoothly running clock now :-)

thanks !

On 05/27/2014 04:52 PM, Mark Crossley wrote:

Version 0.14.9 uploaded that addresses this issue, can you confirm it is fixed?

— Reply to this email directly or view it on GitHub https://github.com/HanSolo/SteelSeries-Canvas/issues/13#issuecomment-44286745.

mcrossley commented 10 years ago

Thanks for the confirmation