HanSolo / SteelSeries-Canvas

The HTML5 Canvas port of the SteelSeries component library. Mainly contains gauges.
120 stars 76 forks source link

Dial Values not scaling #17

Closed gasthecat closed 9 years ago

gasthecat commented 9 years ago

Hi Mark, I've just updated from 0.11.13 of the SteelSeries library to 0.14.14. It looks like the values on the Radial Gauge don't scale up ie make the gauge bigger the numbers look smaller. image Thanks GtC

mcrossley commented 9 years ago

Good catch, a single missing space in a string in the Radial gauge. It looks like that mistake has been there forever.

mcrossley commented 9 years ago

Fixed in v0.14.15.

gasthecat commented 9 years ago

Hi Mark,Thanks for the very quick update on the dial scaling issue. I've come across (probably not a bug more a missing function) a feature of the Display Gauge (both Single and Multi)There is no .getValue Function. is that by design? Question on the OdoMeter incorporated in the Radial gauge can the decimal (Red on White) be removed (true/false switch) and can it be scaled ? Thanks for all your hard work it sure saves me a lot of development time. RegardsColin.

  From: Mark Crossley <notifications@github.com>

To: HanSolo/SteelSeries-Canvas SteelSeries-Canvas@noreply.github.com Cc: gasthecat northcat@gasthecat.co.uk Sent: Tuesday, 31 March 2015, 16:10 Subject: Re: [SteelSeries-Canvas] Dial Values not scaling (#17)

Fixed in v0.14.15.— Reply to this email directly or view it on GitHub.

mcrossley commented 9 years ago

"I've come across (probably not a bug more a missing function) a feature of the Display Gauge (both Single and Multi)There is no .getValue Function. is that by design?"

More, it was never added.

"Question on the OdoMeter incorporated in the Radial gauge can the decimal (Red on White) be removed (true/false switch) and can it be scaled ?"

The odometer is a separate object with its own initialisation parameters, the two of interest to you are probably "digits" (default 6), and "decimals" (default 1)

So set

    params = {
        //...,
        odometerParams : {
            digits: 6,
            decimals: 0
        }
    };

to suppress the decimal display with a total of six figures visible. See the odometer 'gauge' for all the parameters available.

Can it be scaled - no, it is a fixed size in relation to the gauge, apart from the number of digits. You can create a separate odometer in its own canvas though.

gasthecat commented 9 years ago

Hi Mark,Again thanks for the super fast response, very sneaky putting configs inside a config!The main reason why I've gone for the Odo within the Radial so that the pointer will ride over the Odo. One more Question but not the last, is there a way to reduce he frame size I'd like one that's about 10px wide.The Radial looks unfinished without the frame but the std one is just too chunky. Again thanks for your work. 

 From: Mark Crossley <notifications@github.com>

To: HanSolo/SteelSeries-Canvas SteelSeries-Canvas@noreply.github.com Cc: gasthecat northcat@gasthecat.co.uk Sent: Tuesday, 7 April 2015, 21:02 Subject: Re: [SteelSeries-Canvas] Dial Values not scaling (#17)

"I've come across (probably not a bug more a missing function) a feature of the Display Gauge (both Single and Multi)There is no .getValue Function. is that by design?"More, it was never added."Question on the OdoMeter incorporated in the Radial gauge can the decimal (Red on White) be removed (true/false switch) and can it be scaled ?"The odometer is a separate object with its own initialisation parameters, the two of interest to you are probably "digits" (default 6), and "decimals" (default 1)So set params = { //..., odometerParams : { digits: 6, decimals: 0 } };to suppress the decimal display with a total of six figures visible. See the odometer 'gauge' for all the parameters available.Can it be scaled - no, it is a fixed size in relation to the gauge, apart from the number of digits. You can create a separate odometer in its own canvas though.— Reply to this email directly or view it on GitHub.

mcrossley commented 9 years ago

No, the radial frame is a fixed size, I did look at making it a configurable width some time ago, but there are a lot of hard coded values would need to change - I just don't have the time at the moment.

On 7 April 2015 at 22:40, gasthecat notifications@github.com wrote:

Hi Mark,Again thanks for the super fast response, very sneaky putting configs inside a config!The main reason why I've gone for the Odo within the Radial so that the pointer will ride over the Odo. One more Question but not the last, is there a way to reduce he frame size I'd like one that's about 10px wide.The Radial looks unfinished without the frame but the std one is just too chunky. Again thanks for your work.

From: Mark Crossley notifications@github.com To: HanSolo/SteelSeries-Canvas SteelSeries-Canvas@noreply.github.com Cc: gasthecat northcat@gasthecat.co.uk Sent: Tuesday, 7 April 2015, 21:02 Subject: Re: [SteelSeries-Canvas] Dial Values not scaling (#17)

"I've come across (probably not a bug more a missing function) a feature of the Display Gauge (both Single and Multi)There is no .getValue Function. is that by design?"More, it was never added."Question on the OdoMeter incorporated in the Radial gauge can the decimal (Red on White) be removed (true/false switch) and can it be scaled ?"The odometer is a separate object with its own initialisation parameters, the two of interest to you are probably "digits" (default 6), and "decimals" (default 1)So set params = { //..., odometerParams : { digits: 6, decimals: 0 } };to suppress the decimal display with a total of six figures visible. See the odometer 'gauge' for all the parameters available.Can it be scaled - no, it is a fixed size in relation to the gauge, apart from the number of digits. You can create a separate odometer in its own canvas though.— Reply to this email directly or view it on GitHub.

— Reply to this email directly or view it on GitHub https://github.com/HanSolo/SteelSeries-Canvas/issues/17#issuecomment-90740120 .