SlimClockSkin uses default Locale in DateTimeFormatter

HanSolo / medusa

A JavaFX library for Gauges

Apache License 2.0

692 stars 131 forks source link

SlimClockSkin uses default Locale in DateTimeFormatter #138

Closed kosmelju closed 6 years ago

kosmelju commented 6 years ago

There is day of the week displayed in default system locale when using SlimClockSkin and setting dateVisible(true). Probably DateTimeFormatter.ofPattern(String pattern, Locale locale) with user defined clock's Locale should be used instead of DateTimeFormatter.ofPattern(String pattern) on line 46 in SlimClockSkin.java (private static final DateTimeFormatter DATE_TEXT_FORMATTER = DateTimeFormatter.ofPattern("cccc");). It would be also nice to be able to show/hide "day" and "date" separately.

HanSolo commented 6 years ago

Thanx for the report...fixed with commit a8282dbd7c3882087211a614c366437fea357a4b :)

kosmelju commented 6 years ago

thank you very much!