card-reducer branch: make throw it in a hole work

[Zamiell]

i did some work on this, i think that all that is left is for rob to fix the onHoleChanged() function

[robertos]

done?

[Zamiell]

i tested it and experienced the following bug:

• clue some 1s
• play some 1s
• terminate
• the play stacks glitch out - some of the 1s are completely hidden, some of the 1s slowly animate from the center of the screen to their proper stacks.
  • after the slow animation is finished, the rest of the 1s appear

[Zamiell]

furthermore:

the empathy in "throw it in a hole" is wrong. we assume that other players know the cards they played. (one small issue is the call to "revealCard" using the information we know, but the main problem is cards that will be drawn later)

[Zamiell]

actually i guess this isn't a very safe assumption, because it could be wrong

[Zamiell]

looks like it is fixed now thanks to rob

[Zamiell]

not fixed, still bugs out after refreshing and then terminating the game

[Zamiell]

any misplay animations also happen, which is buggy

[Zamiell]

i guess misplay animations to the discard pile are expected? not sure how it should work

[robertos]

There's two consistent options:

1. no animations for anything, animate fast
2. misplays and playstacks animate (current) and one less consistent option
3. playstacks animate, misplays don't (add a fade/teleport)

[robertos]

There's also a funky, more complete change which is to make the reveal slower and more tense, by revealing the cards one by one and animating to the playstack or misplay. It would take much longer, but it would be a suspense reveal :) -- definitely not for this issue, but can be added as another issue if desired (P3)

[robertos]

I might go with option 1. (no anims) since that's what's currently on H.L

[Zamiell]

im fine with option 1

[Zamiell]

looks fixed, thanks