In-game hypo inconsistent unknown cards.

[timotree3]

1. See a drawn card in the present game
2. Enter replay and rewind to the first turn
3. Enter in-game hypo
   • Any drawn card that you've seen in the present game will have the "blank" back
   • Any card that you haven't seen in the present game will have the "unknown/empathy" back.

This does not seem good.

Ideas:

• Show the card empathy back for hidden cards in hypo instead of the blank back.
• Show the blank back for unknown cards in hypo instead of the empathy back.
• Unconditionally enable shown drawn cards in in-game hypo

[Zamiell]

in my mind, the behavior should be to only show the blank back for hypothetical cards, not real cards

meaning that:

(pseudocode)
const orderOfLastDrawnCard = ?; // Derived from globals.state.ongoingGame
if (card.order > orderOfLastDrawnCard) {
  // Show blank card back
} else {
  // Show normal, fully revealed card back
}

[timotree3]

what does last drawn card mean? last drawn card on the turn where the hypothetical started? or last drawn card in the present?

[Zamiell]

const orderOfLastDrawnCard = ?; // Derived from globals.state.ongoingGame

meaning the last drawn card in the present, because globals.state.ongoingGame is the present GameState

[timotree3]

Well then that's already whats happening

[Zamiell]

no it isn't, what is currently happening is

(pseudocode)
const orderOfLastDrawnCard = ?; // Derived from globals.state.replay.states[turnHypoStarted]
if (card.order > orderOfLastDrawnCard) {
  // Show blank card back
} else {
  // Show normal, fully revealed card back
}

[Zamiell]

the "Derived from" part is different in the two code snippets

[timotree3]

Read the original post again. I think you've got it wrong.

• Any drawn card that you've seen in the present game will have the "blank" back
• Any card that you haven't seen in the present game will have the "unknown/empathy" back.

This is what's currently happening as decribed in the OP and this is the same as your "proposal" with ongoingGame

[Zamiell]

oh i see

[Zamiell]

your screenshot isn't very good, here's a better one that showcases the bug: slot 1 is not known in the present slot 2 is known in the present

[Zamiell]

in "Hide Drawn Cards Mode" (the defualt):

• i propose that slot 1 should be blank (like slot 2 is)
• i propose that slot 2 should be normal, but unrevealed (like slot 1 is)

in "Show Drawn Cards" mode:

• i propose that slot 1 should be blank (like slot 2 is)
• i propose that slot 2 should be fully revealed (like how it is when you draw a known card in an in-game replay)

[Zamiell]

can we write tests for this? probably not?

[padiwik]

So it's not really "drawn cards", but a new thing like "Show cards in hand"? And then shared replay hypo will need toggle buttons for both of these features to avoid conflating them?

[Zamiell]

So it's not really "drawn cards", but a new thing like "Show cards in hand"?

right but you just combine those two things because we don't want to have a separate button for just that imo