Hanabi-Live / hanabi-live

A web server that allows people to play Hanab, a cooperative card game of logic and reasoning.
https://hanab.live
GNU General Public License v3.0
178 stars 118 forks source link

delete old_password_hash in database #2050

Open hanabi-live-issues-bot[bot] opened 3 years ago

hanabi-live-issues-bot[bot] commented 3 years ago

Issue opened by Discord user: Zamiel#8743

Zamiell commented 3 years ago

also set password_hash to NOT NULL

DrAnax commented 2 years ago
  1. There are users on the database with NULL on password_hash (last login: 2020-05-08)
  2. old_password_hash still exists on the codebase

SELECT users.id, users.username, COUNT(DISTINCT games.id) as num_games FROM games, game_participants, users WHERE games.id = game_participants.game_id AND game_participants.user_id = users.id and users.password_hash IS NULL GROUP BY users.id order by num_games DESC LIMIT 20

Zamiell commented 2 years ago

let's leave it for another year before deleting it