Hanabi-Live / hanabi-live

A web server that allows people to play Hanab, a cooperative card game of logic and reasoning.
https://hanab.live
GNU General Public License v3.0
179 stars 118 forks source link

[Throw it in a Hole] Fix sound & stack bugs #2928

Closed NZadeh closed 9 months ago

NZadeh commented 9 months ago

As I was trying to tackle https://github.com/Hanabi-Live/hanabi-live/issues/2875, I thought this low-hanging fruit would be a good way to start. Does this commit look okay to you?

EDIT: This is the error that should no longer be reachable: https://github.com/Hanabi-Live/hanabi-live/blob/main/packages/client/src/game/ui/reactive/getSoundType.ts#L208

We're now computing the number of blind "plays" successfully. Previously, it was set to 0 for TIIAH bombs.

NZadeh commented 9 months ago

@Zamiell PTAL!

NZadeh commented 9 months ago

I also folded the stack fixes into this change.

image

I'm... sort of holding on for dear life in terms of figuring out how to actually contribute to this repo, and this whole forking and merging model is super confusing rn. So hopefully everything is "correct-enough" process-wise and sorry I couldn't do it better.

Zamiell commented 9 months ago

I'm... sort of holding on for dear life in terms of figuring out how to actually contribute to this repo, and this whole forking and merging model is super confusing rn

if you aren't familiar with github then you can dm me and i can help, otherwise im sure you can just youtube any old "how to do a PR" explainer video, its fairly straightforward

NZadeh commented 9 months ago

Alright should be fixed, and ./lint.sh passes locally for me! Thanks for the help! :D

Zamiell commented 9 months ago

good PR thanks