Hanabi-Live / hanabi-live

A web server that allows people to play Hanab, a cooperative card game of logic and reasoning.
https://hanab.live
GNU General Public License v3.0
177 stars 114 forks source link

Keep Chop Move info when card is clued #2962

Open eralmeida opened 2 weeks ago

eralmeida commented 2 weeks ago

Is your feature request related to a problem? Please describe. I find myself missing the Focus when I get a play clue on multiple chop moved cards. For example : I have r3 r5 (previously chop moved) in slots #4 and #5. They are both marked with the White outline and the respective [cm] notes.

Later on they're both clued with a Red Clue. Although my notes would be enough info to figure out the focus, the play clue outline (Orange) leads me to play what I perceive as Chop (the r5).

Describe the solution you'd like The first solution I thought of, was to simply add a multi-colour outline (orange and white) when a Chop Moved card is clued. The same could probably be applied to cards previously finessed and later clued (orange and blue).

Describe alternatives you've considered This solution may not be suitable for the colorblind. Maybe there's a way to add a Badge/Icon like in DDA (Blue Question mark icon)

Zamiell commented 2 weeks ago

is this a duplicate of #2946?

eralmeida commented 2 weeks ago

is this a duplicate of #2946?

Apparently it is. Should I close the issue?

Zamiell commented 2 weeks ago

Unless you have a different proposition than "make a new colored border", then yes

eralmeida commented 2 weeks ago

Unless you have a different proposition than "make a new colored border", then yes

As I said, the only thing I can think of is adding a new badge/icon, like when cards are Unique or DDA.

Zamiell commented 2 weeks ago

im not in love with that idea because the new hypothetical badge would only represent a note, whereas all of the existing badges represent real information about the card

ricardodd2 commented 2 weeks ago

I think keeping the white boarder is the simplest solution. It happened to me aswell when I was distracted to mess up focus when cards where chop moved. I don't have this issue to often but I beleive keeping the boarder is an improvment. If a card was cm and it gets a clue, having the boarder indicates that extra info. Another card which is actually chop moved will still be recognizable since it won't have positive information and will show the gray back

Zamiell commented 2 weeks ago

I don't want to keep the white border when a card is clued. The reason is because definitionally, a chop moved card is an unclued card. When a card is positively clued, then it immediately loses the cm status. Thus, having both a chop move border and a positive clue at the same time is confusing and goes against what the definition is.

argothiel commented 2 weeks ago

It goes against the definition, but it matches the note on the card. If somebody has [cm] written on a clued card, it's on them, and the border should be present. Similarly, if somebody writes [f] on a clued card, I wouldn't mind a blue border.

ricardodd2 commented 2 weeks ago

To me is not so much about definition but more about practicality. It seems a little more practical to keep the white border only so that when a clue is given touching a cm card and an unclued card the focus is immediately clear without having to remember and/or replay. I don't really think it would be confusing to have a clued card with a white border to be honest (but I cannot really tell unless I try it)

I have also been thinking how the focus of a clue touching new cards and already gotten cards is not confusing and I beleive arrows have different colors. Maybe another solution would be changing the color of clues for previously untouched cm cards. Idk if this can be problematic to implement since it relies on notes, though