Hanabi-Live / hanabi-live

A web server that allows people to play Hanab, a cooperative card game of logic and reasoning.
https://hanab.live
GNU General Public License v3.0
178 stars 118 forks source link

label on color clues #975

Closed tyrcho closed 4 years ago

tyrcho commented 4 years ago

Hi,

First time on the site today. Really well done ! (I'm a regular on BGA).

One small improvement would be to label the clues with the same icons. I'm color-blind and it took me some time to figure out which color clue to give !

And maybe to mark clearly when it's my turn to play. For the first game I kept looking for this information, I only saw it when it was the other player's turn.

Zamiell commented 4 years ago

One small improvement would be to label the clues with the same icons.

i dont understand this request, you mean inside of the circles?

note that on hanabi live, colors are distinct from suits. this is because we regularly play with various dual-color variants, where one suit is touched by two separate colors. give it a try and see what i mean.

I'm color-blind and it took me some time to figure out which color clue to give !

do you have the color blind mode enabled?

And maybe to mark clearly when it's my turn to play.

what specifically do you suggest

tyrcho commented 4 years ago

about the clues :

image

it took me some time to make the link between which clue I can give and which zone cards are to be played.

Maybe you could put the same symbols on the clues ? Or align the clues with the play area ?

tyrcho commented 4 years ago

now I have enable color-blind mode !

image

It's still not obvious to me that R clue has something to do with the first 'o' playing area.

tyrcho commented 4 years ago

about marking that it's my turn, maybe some text in this area image

similar to this one image

again, it's pretty obvious after the first game, but it would help a complete newcomer

Zamiell commented 4 years ago

about marking that it's my turn, maybe some text in this area

the area in the screenshot is covered by the clue ui. maybe text that appears on top and fades out?

tyrcho commented 4 years ago

maybe some text under "give clue" ? the point is sometimes you are busy looking some rule, convention ... and you miss the animation. Then you look at the site and wonder who's turn it is.

Zamiell commented 4 years ago

there is no room for that in keldon mode, as you can see:

image

rogers-j commented 4 years ago

(Try not to have two issues in your issue. Making a second is free.)

With colorblind mode on, every red card has its letter, right? So your only problem in this screenshot is that the base of the stack does not have a letter? That seems like something it would be easy for colorblind mode to change.

rogers-j commented 4 years ago

On the other hand, I am still not sure if this additional information would help. If there are no red cards played, then you would be able to verify this by seeing that none of the played cards have the letter R on them.

Zamiell commented 4 years ago

i think for simplicity ill just make the suit color match the color letter for non-dualcolor games

rogers-j commented 4 years ago

Don't they match? That doesn't seem like the problem here

rogers-j commented 4 years ago

My way seems far simpler. You just have to remove the special case that stops the colorblind letter appearing on stack bases.

Zamiell commented 4 years ago

@tyrcho what about this:

image

Zamiell commented 4 years ago

or would you prefer that they are filled in with white

tyrcho commented 4 years ago

that would help a lot ! (pictogram + color)

Zamiell commented 4 years ago

they are kinda hard to see, but ok

tyrcho commented 4 years ago

What could help also, is to shift the colors and symbols since some are more similar than others.

For example: 1 - yellow triangle 2 - blue square 3 - red "Pi" 4 - green cross 5 - purple circle

Zamiell commented 4 years ago

the colors are in the order of the colors in the rainbow, i dont want to rearrange them

Zamiell commented 4 years ago

the symbols roughly match the suits in the vanilla edition of hanabi, so i dont want to arbitrarily reassign those either

tyrcho commented 4 years ago

for me it's actually very visible (black over color), but I'm also fine with white background or filling

tyrcho commented 4 years ago

well, in vanilla Hanabi there was White color which has different meaning here ...

tyrcho commented 4 years ago

anyways symbols in the clues would really help me !

Zamiell commented 4 years ago

indeed, white is just remapped to purple

tyrcho commented 4 years ago

a suggestion is to use more light and dark tones on similar colors (there are good resources on "color blind palette" on internet). For instance on hanabi.live : lighter yellow, darker green, lighter blue (purple already quite dark)

Zamiell commented 4 years ago

https://github.com/Zamiell/hanabi-live/blob/master/public/js/src/data/colors.json

you need to specify exactly what you want

rogers-j commented 4 years ago

If you're going to the trouble of putting the suits there, why even color the background rounded rectangles?

e.g. color_suit_clue

Zamiell commented 4 years ago

i filled them as white instead so that they match the numbers

rogers-j commented 4 years ago

Isn't that also what I did? 🙃 Or do you mean you did the opposite? That seems like way more trouble.

Zamiell commented 4 years ago

the opposite

rogers-j commented 4 years ago

color_suit_clue

Zamiell commented 4 years ago

@tyrcho what do you like better

tyrcho commented 4 years ago

I prefer the simplest one:

image

You could even simplify by removing the (brown ?) outline with rounded borders outside the color clue and make it all red, yellow ...

tyrcho commented 4 years ago

color suggestion to make them stand out more :

https://coolors.co/e60000-e6e600-00aa00-0055ff-8800aa

I checked on their color blind mode (the glasses) and for other kind of color blindness it looks fine too.

tyrcho commented 4 years ago

about removing the brown outline ... color blindness is related to the relative area of color spots, so making the spot slightly bigger with the relevant color also helps !

Zamiell commented 4 years ago

619b527e2a6d0cb4520c0db92c2e65ff0301c97b those colors will be in the next update (wont be for a few days)

about removing the brown outline ... color blindness is related to the relative area of color spots, so making the spot slightly bigger with the relevant color also helps !

i dont know what this means

tyrcho commented 4 years ago

thanks for the colors update !

sorry about my english ... What I mean is that it's easier for me to see a larger spot of the same color. So replacing the brown outline image

with a full red clue would make it easier to see.

Zamiell commented 4 years ago

i can't remove the outline because then there would be no indication of which button you have selected

Zamiell commented 4 years ago

going to close this now, open a new issue with any other suggestions beyond what is currently implemented