search

HanashiDev / Haltestellenmonitor-v3

GNU General Public License v3.0
1 stars 3 forks source link

Added capability for Widgets to show next favourite stop #24

Closed t0mbrn closed 6 months ago

t0mbrn commented 8 months ago

Implementation of this issue.

I'm not sure if the update speed of the stop selection is sufficient. As I am unfortunately unable as of now to test the PR on my iPhone I have to push this here without real world testing.

I implemented an option in the widgets' settings to always show the next favourite stop (next as in location). The widgets functionality should not be impacted although I don't know if that feature impacts battery life when activated. Do you think there should be a warning for that? (As mentioned I wasn't able to test it on device, only on simulator).

Is the option I chose to retrieve the location data viable or is the one of your "original" location manger preferred? Would locationManager.startMonitoringSignificantLocationChanges() help reduce battery usage?

I hope this PR will be helpful for you guys, if I should add anything more or change something please tell me! Best, Tom

t0mbrn commented 8 months ago

Hi, thank you for your contribution. I haven't tested the code yet, but I have added my first comments.

Will fix this. Thanks for the feedback!

t0mbrn commented 8 months ago

now all things you mentioned should be fixed.

Hanashi commented 7 months ago

Hello, the code looks good. I will test it and then approve it. I'll get to it sometime this week :)