HandBrake / HandBrake

HandBrake's main development repository
https://handbrake.fr
Other
17.78k stars 1.34k forks source link

1.2.0 puts DV on side #1764

Closed mar3ld closed 5 years ago

mar3ld commented 5 years ago

Description of the problem

When importing a DV encoded interlaced PAL VHS into version 1.2.0, Handbrake puts the video on the side (for the lack of better words). See the first picture below. This did not happen with the previous 1.1.2 version, see the second picture.

Although I can rotate the video CW 90° using the built in Rotate feature, the initial problem seems to make it impossible to have the video deinterlaced at the same time. It seems that the deinterlacing detection happens before any Rotate features apply. No deinterlacing will happen now and the rotated but still interlaced image will be burned into the progressive video (as can be seen in the preview portion of the pictures included below, if you look closely).

Handbrake VHS-DV 1.2.0: handbrake vhs-dv 1 2 0 Handbrake VHS-DV 1.1.2: handbrake vhs-dv 1 1 2

HandBrake version

Handbrake 1.2.0

Operating system and version

macOS 10.13.6

Error message text or screenshot

There are no error messages. I just can't convert interlaced VHS DV into progressive h264 anymore, without reverting to 1.1.2.

HandBrake Activity Log

[06:23:04] macgui: Handbrake Version: 1.2.0  (2018122200)
[06:23:04] hb_init: starting libhb thread
[06:23:04] hb_init: starting libhb thread
[06:23:07] macgui: trying to open a folder or file
[06:23:07] macgui: ScanCore scanning titles with a duration of 10 seconds or more
[06:23:07] CPU: Intel(R) Xeon(R) CPU           E5620  @ 2.40GHz
[06:23:07]  - logical processor count: 16
[06:23:07] hb_scan: path=/Volumes/BL640/WorkInProgress/VHS/Bounced Files/Siv 2001 Full 2.mov, title_index=0
udfread ERROR: ECMA 167 Volume Recognition failed
disc.c:323: failed opening UDF image /Volumes/BL640/WorkInProgress/VHS/Bounced Files/Siv 2001 Full 2.mov
disc.c:424: error opening file BDMV/index.bdmv
disc.c:424: error opening file BDMV/BACKUP/index.bdmv
[06:23:07] bd: not a bd - trying as a stream/file instead
libdvdnav: Using dvdnav version 6.0.0
libdvdread: Encrypted DVD support unavailable.
libdvdread:DVDOpenFileUDF:UDFFindFile /VIDEO_TS/VIDEO_TS.IFO failed
libdvdread:DVDOpenFileUDF:UDFFindFile /VIDEO_TS/VIDEO_TS.BUP failed
libdvdread: Can't open file VIDEO_TS.IFO.
libdvdnav: vm: failed to read VIDEO_TS.IFO
[06:23:07] dvd: not a dvd - trying as a stream/file instead
[mov,mp4,m4a,3gp,3g2,mj2 @ 0x7fcc58895a00] Referenced QT chapter track not found
Input #0, mov,mp4,m4a,3gp,3g2,mj2, from '/Volumes/BL640/WorkInProgress/VHS/Bounced Files/Siv 2001 Full 2.mov':
  Metadata:
    major_brand     : qt  
    minor_version   : 537199360
    compatible_brands: qt  
    creation_time   : 2018-11-30T14:18:14.000000Z
    com.apple.quicktime.player.movie.audio.gain: 1.000000
    com.apple.quicktime.player.movie.audio.treble: 0.000000
    com.apple.quicktime.player.movie.audio.bass: 0.000000
    com.apple.quicktime.player.movie.audio.balance: 0.000000
    com.apple.quicktime.player.movie.audio.pitchshift: 0.000000
    com.apple.quicktime.player.movie.audio.mute: 
    com.apple.quicktime.player.movie.visual.brightness: 0.000000
    com.apple.quicktime.player.movie.visual.color: 1.000000
    com.apple.quicktime.player.movie.visual.tint: 0.000000
    com.apple.quicktime.player.movie.visual.contrast: 1.000000
    com.apple.quicktime.player.version: 7.6.6 (7.6.6)
    com.apple.quicktime.version: 7.7.3 (3014.8) 0x7738000 (Mac OS X, 10.13.6, 17G4015)
    timecode        : 01:00:00:00
  Duration: 00:20:45.20, start: 0.000000, bitrate: 31105 kb/s
    Stream #0:0(und): Video: dvvideo (dvcp / 0x70637664), yuv420p(smpte170m/bt470bg/bt709, bottom coded first (swapped)), 720x576 [SAR 16:15 DAR 4:3], 28800 kb/s, SAR 59:54 DAR 295:216, 25 fps, 25 tbr, 25k tbn, 25 tbc (default)
    Metadata:
      rotate          : 0
      creation_time   : 2018-11-30T14:18:14.000000Z
      handler_name    : Apple Video Media Handler
      encoder         : DV - PAL
    Side data:
      displaymatrix: rotation of -0.00 degrees
    Stream #0:1(sve): Audio: pcm_s24be (in24 / 0x34326E69), 48000 Hz, stereo, s32 (24 bit), 2304 kb/s (default)
    Metadata:
      rotate          : 0
      creation_time   : 2018-11-30T14:19:14.000000Z
      handler_name    : Apple Sound Media Handler
    Stream #0:2(eng): Data: none (tmcd / 0x64636D74)
    Metadata:
      rotate          : 0
      creation_time   : 2018-11-30T14:19:25.000000Z
      handler_name    : Time Code Media Handler
      timecode        : 01:00:00:00
    Stream #0:3(eng): Subtitle: mov_text (text / 0x74786574), 160x48
    Metadata:
      rotate          : 0
      creation_time   : 2018-12-21T06:34:21.000000Z
      handler_name    : Apple Text Media Handler
[06:23:07] scan: decoding previews for title 1
[mov,mp4,m4a,3gp,3g2,mj2 @ 0x7fcc5983ca00] Referenced QT chapter track not found
[06:23:07] scan: audio 0x1: pcm_s24be, rate=48000Hz, bitrate=2304000 Unknown (pcm_s24be) (2.0 ch)
[06:23:08] scan: 10 previews, 576x720, 25.000 fps, autocrop = 12/26/20/8, aspect 1:1.33, PAR 15:16
[06:23:08] libhb: scan thread found 1 valid title(s)
[06:23:08] macgui: ScanCore scan done

(First time poster. Not a coder. Just tell me if I need to include anything else.)

jstebbins commented 5 years ago

This is very likely the same as https://github.com/HandBrake/HandBrake/issues/1750 Could you try the nightly build and verify this has been fixed? https://handbrake.fr/nightly.php

sr55 commented 5 years ago

Yeh, it is. Same 0 rotation flag.

It should be fixed in 1.2.1 (Will be released sometime in the near future) or the nightly builds.

If you still have issues, we can re-open this.

mar3ld commented 5 years ago

Confirmed. Rotation error is fixed in nightly Version 20190103193954-29eb716-master (2019010401).

sr55 commented 5 years ago

Thanks for reporting back!