HandHeldLegend / HOJA-LIB-ESP32

An API project to emulate various retro and modern controllers on ESP32.
Other
56 stars 12 forks source link

Added two more core_ns_start functions #10

Closed JPZV closed 1 year ago

JPZV commented 1 year ago

This will allow to use the library as a git submodule without needing to fork or to use any workaround like git patches.

Breaking changes:

core_ns_start is still present so there will be no compilation error, but it may generate an error on new and current installments, as it'll use the saved controller type which may differ from the physical/original/intended one. I'd suggest to mark it as deprecated and to incite to use either core_ns_start_with_default_type (for customizable hardware) or core_ns_start_with_controller_type.

mitchellcairns commented 1 year ago

Current plans will be to have something like ns_set_sub_type(TYPE). In this way, when the start core function is called, it will use that type and set up the dependent parameters accordingly. Let me know if this suffices and I will be working on this over the next couple weeks.

JPZV commented 1 year ago

That would be great, because nowadays I have to set a patch on my repositories as I have this library as a submodule.

Meanwhile, is it possible to delete this line? Because that line forces the controller to be a SNES classic one no matter what. While you create the ns_set_sub_type(TYPE) function, I can do some workaround with the settings on my projects, at least for now.

mitchellcairns commented 1 year ago

New functionality added to change controller type in user-code.

See commit info here.