Closed caoko closed 1 year ago
@caoko It seems that you broke the unit tests?
[xUnit.net 00:00:06.69] HandlebarsDotNet.Helpers.Tests.Helpers.HumanizerHelpersTests.Truncate(length: 2, separator: null, truncator: "FixedNumberOfWords", truncateFrom: null, expected: "Long text?") [FAIL]
Expected result to be
"Long text?", but
"Long text…" differs near "…" (index 9).
Can you please revert the changes to the unit-tests?
(Maybe you are running locally in a different Culture?)
@caoko It seems that you broke the unit tests?
[xUnit.net 00:00:06.69] HandlebarsDotNet.Helpers.Tests.Helpers.HumanizerHelpersTests.Truncate(length: 2, separator: null, truncator: "FixedNumberOfWords", truncateFrom: null, expected: "Long text?") [FAIL] Expected result to be "Long text?", but "Long text…" differs near "…" (index 9).
Can you please revert the changes to the unit-tests?
(Maybe you are running locally in a different Culture?)
Yes, it seems to be a file encoding problem. File encoding should be utf-8...
You can ignore the changes.
@caoko Can you revert these changes to that file please?
yes. reverted these file.
Merging #66 (8a9c4a1) into master (064db8c) will increase coverage by
2.22%
. The diff coverage is87.70%
.
@@ Coverage Diff @@
## master #66 +/- ##
==========================================
+ Coverage 43.93% 46.15% +2.22%
==========================================
Files 32 37 +5
Lines 2290 2405 +115
Branches 325 343 +18
==========================================
+ Hits 1006 1110 +104
- Misses 1197 1204 +7
- Partials 87 91 +4
Impacted Files | Coverage Δ | |
---|---|---|
...rc/Handlebars.Net.Helpers/Helpers/StringHelpers.cs | 73.12% <64.28%> (-0.83%) |
:arrow_down: |
src/Handlebars.Net.Helpers/HandlebarsHelpers.cs | 80.90% <64.51%> (+0.03%) |
:arrow_up: |
...Helpers.Core/Extensions/ParameterInfoExtensions.cs | 66.66% <66.66%> (ø) |
|
...c/Handlebars.Net.Helpers/Helpers/EvaluateHelper.cs | 78.57% <78.57%> (ø) |
|
...lebars.Net.Helpers.Core/Parsers/ArgumentsParser.cs | 94.59% <93.75%> (+2.59%) |
:arrow_up: |
...lpers.Core/Attributes/HandlebarsWriterAttribute.cs | 100.00% <100.00%> (ø) |
|
...rc/Handlebars.Net.Helpers.Core/Utils/ArrayUtils.cs | 100.00% <100.00%> (ø) |
|
...rs.Net.Helpers/Extensions/IHandlebarsExtensions.cs | 100.00% <100.00%> (ø) |
|
...ars.Net.Helpers/Extensions/MethodBaseExtensions.cs | 13.04% <100.00%> (+13.04%) |
:arrow_up: |
...c/Handlebars.Net.Helpers/Helpers/BooleanHelpers.cs | 100.00% <100.00%> (ø) |
|
... and 6 more |
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
…fills.AsyncLocal`1'