Handlebars-Net / Handlebars.Net.Helpers

Handlebars.Net helpers in the categories: 'Boolean', 'Constants', 'Enumerable', 'Environment', 'Math', 'Regex', 'String', 'DateTime' and 'Url'.
MIT License
38 stars 14 forks source link

String.Substring helper #76

Closed Andras-Csanyi closed 1 year ago

Andras-Csanyi commented 1 year ago

This PR brings the following changes:

Notes:

Question:

I'm looking forward to reading your feedback!

codecov[bot] commented 1 year ago

Codecov Report

Merging #76 (793725e) into master (11cf645) will increase coverage by 0.20%. The diff coverage is 100.00%.

:exclamation: Current head 793725e differs from pull request most recent head 24740a0. Consider uploading reports for the commit 24740a0 to get more accurate results

@@            Coverage Diff             @@
##           master      #76      +/-   ##
==========================================
+ Coverage   44.80%   45.01%   +0.20%     
==========================================
  Files          41       41              
  Lines        2649     2659      +10     
  Branches      364      366       +2     
==========================================
+ Hits         1187     1197      +10     
  Misses       1359     1359              
  Partials      103      103              
Impacted Files Coverage Δ
...rc/Handlebars.Net.Helpers/Helpers/StringHelpers.cs 78.48% <100.00%> (+0.94%) :arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

StefH commented 1 year ago

CI Build is fine.

StefH commented 1 year ago
  1. I see that test coverage can be increased by addtional test cases covering exception paths, do you see value in these? I'm happy to provide them as my time allows.
  2. I see that the the line endings are mixed LF and CRLF, it is intentional?
  3. Shall I extend the documentation with the new feature once it is approved and merged?

1--> Not really required.

2-->Not intentional, just an error I think...

3-->I'm not sure you can update the WIKI directly. But you can copy-paste the updates maybe here?