Closed Andras-Csanyi closed 1 year ago
Merging #76 (793725e) into master (11cf645) will increase coverage by
0.20%
. The diff coverage is100.00%
.:exclamation: Current head 793725e differs from pull request most recent head 24740a0. Consider uploading reports for the commit 24740a0 to get more accurate results
@@ Coverage Diff @@
## master #76 +/- ##
==========================================
+ Coverage 44.80% 45.01% +0.20%
==========================================
Files 41 41
Lines 2649 2659 +10
Branches 364 366 +2
==========================================
+ Hits 1187 1197 +10
Misses 1359 1359
Partials 103 103
Impacted Files | Coverage Δ | |
---|---|---|
...rc/Handlebars.Net.Helpers/Helpers/StringHelpers.cs | 78.48% <100.00%> (+0.94%) |
:arrow_up: |
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
CI Build is fine.
1--> Not really required.
2-->Not intentional, just an error I think...
3-->I'm not sure you can update the WIKI directly. But you can copy-paste the updates maybe here?
This PR brings the following changes:
Notes:
end
parameter asdefault
and it introduces a quirky corner case belowSubstring "foobar" 0 0
will resultfoobar
due todefault(int) == 0
so, the code thinksend
parameter were not be provided. From usage point of view I don't know when I would need aSubstring "foobar" 0 0
. I'm open for suggestions. The case is provided by a test case.Substring "" 0
works,string.Substring()
allows it. This is the reason onlynull
input is checked by Guard and empty has an additional check.Question:
I'm looking forward to reading your feedback!