search

Handlebars-Net / Handlebars.Net.Helpers

Handlebars.Net helpers in the categories: 'Boolean', 'Constants', 'Enumerable', 'Environment', 'Math', 'Regex', 'String', 'DateTime' and 'Url'.
MIT License
40 stars 15 forks source link

Fixed casting problems in ExecuteUtils breaking EnumerableHelpers #88

Closed HenrikHoyer closed 6 months ago

HenrikHoyer commented 6 months ago
codecov[bot] commented 6 months ago

Codecov Report

Attention: Patch coverage is 71.42857% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 47.27%. Comparing base (2afe410) to head (e50ff49).

Files Patch % Lines
src/Handlebars.Net.Helpers/Utils/ExecuteUtils.cs 71.42% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #88 +/- ## ========================================== + Coverage 46.29% 47.27% +0.97% ========================================== Files 44 44 Lines 2912 2913 +1 Branches 410 411 +1 ========================================== + Hits 1348 1377 +29 + Misses 1440 1412 -28 Partials 124 124 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

StefH commented 6 months ago

@HenrikHoyer

  1. You can mark the comment comments which are fixed as "resolve conversation", this makes it easier to see which one are resolved or still open.

  2. There is a unit-test error: Expected result to be 450.6, but found 450.60000038146973. Use something like this code: result.Should().BeApproximately(450.6, 0.0001);