Handlebars-Net / Handlebars.Net

A real .NET Handlebars engine
MIT License
1.24k stars 214 forks source link

Add `net5` and `net6` as TargetFrameworks #479

Closed oformaniuk closed 5 months ago

sonarcloud[bot] commented 2 years ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

thompson-tomo commented 5 months ago

Closes #573

thompson-tomo commented 5 months ago

@oformaniuk & @StefH I see that this has been sitting around for a while, any chance the conflicts could be resolved and then this merge progressed. :)

oformaniuk commented 5 months ago

@oformaniuk & @StefH I see that this has been sitting around for a while, any chance could the conflicts be resolved and then this merge progressed. :)

I'd be happy to handle merging part if you can handle conflicts :)

thompson-tomo commented 5 months ago

@oformaniuk I will take a look later today to see if I can push changes to this branch.

oformaniuk commented 5 months ago

@oformaniuk I will take a look later today to see if I can push changes to this branch.

If not, it can be done by forking and merging back to this branch via PR 🙂

thompson-tomo commented 5 months ago

@oformaniuk pr #577 has been created to resolve the conflicts and implements the feedback i have above.

StefH commented 5 months ago

@thompson-tomo and @oformaniuk I think it's more clear that this PR is just closed and a new PR is created which only adds the new frameworks.

Side note: do we actually want to add .NET 5 because that one is out of support for some time? And instead just add .NET 6 and .NET 8 because .NET 7 is also almost out of official support?

thompson-tomo commented 5 months ago

@StefH i agree. What I will do tomorrow morning my time is cherry pick the commits on to a new branch from master & then submit that as a fresh pr & close my other pr.

Also no issue on my side with only doing net 6

oformaniuk commented 5 months ago

As agreed, change will be handled in a new PR.

thompson-tomo commented 5 months ago

New PR is #578 which is a nice and clean PR.