search

Handlebars-Net / Handlebars.Net

A real .NET Handlebars engine
MIT License
1.24k stars 214 forks source link

Deprecate SupportLastInObjectIterations #482

Closed orgads closed 2 years ago

oformaniuk commented 2 years ago

Removal of ObjectIteratorValues introduces breaking change to current v2 API as some external users (e.g., Handlebars.Net.Extension.NewtonsoftJson and Handlebars.Net.Extension.Json) depends on current behavior. I'd merge this PR to the new upstream to track v3 milestone

orgads commented 2 years ago

I can revert the file deletion, and mark it as obsolete. Then you can remove it on v3. WDYT?

oformaniuk commented 2 years ago

I can revert the file deletion, and mark it as obsolete. Then you can remove it on v3. WDYT?

In that case we'd need to revert addition of Key to IteratorValues and leave TODO mentioning the intent to do the change.

orgads commented 2 years ago

Why? I just re-added the class, and added [Obsolete] attribute, so extensions can still use it.

Is it ok?

sonarcloud[bot] commented 2 years ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

88.9% 88.9% Coverage
22.9% 22.9% Duplication