Allow slashes properly within escape blocks

Handlebars-Net / Handlebars.Net

A real .NET Handlebars engine

MIT License

1.22k stars 213 forks source link

Allow slashes properly within escape blocks #567

Closed Hoeksema closed 3 months ago

Hoeksema commented 5 months ago

closes #566

The path parsing currently doesn't work properly when there are embedded slashes within an ignore block.

This PR fixes this issue:

No more exceptions thrown when using // within an escaped block
Allowing multiple / to occur within an escape block without breakage

Before, the individual segments between slashes in addition to the entire escaped block were returned by PathInfo. Now, it returns just the latter, which is correct. All existing unit tests still pass and new tests were added to exercise the failing cases in #566.

sonarcloud[bot] commented 5 months ago

Quality Gate passed

Issues
1 New issue

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

Hoeksema commented 5 months ago

Hey @oformaniuk @StefH, hope you're having a great week! Any chance you could review this?

We're looking to keep our code base unforked from origin as much as possible, also so we can keep sending pull requests for issues we find as we productionize this in our system, and need this fix in particular for a critical use case of ours.

EDIT (Mar 7): Did not see any activity here, so we went ahead with forking unfortunately. No need to complete this soon anymore.

oformaniuk commented 3 months ago

@Hoeksema, unfortunately, I was not following the repo closely lately. If you (and your team) is interested in contributing into the project further I'd be happy to include you as contributors.

sonarcloud[bot] commented 3 months ago

Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

Hoeksema commented 3 months ago

@Hoeksema, unfortunately, I was not following the repo closely lately. If you (and your team) is interested in contributing into the project further I'd be happy to include you as contributors.

Thank you for merging the PRs! Feel free to add me as contributor if that feels appropriate. We might need to make some more bug fixes in a quarter or two once we use it more broadly.